Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release detail page #2807

Closed
nlhkabu opened this issue Jan 18, 2018 · 8 comments · Fixed by #2879
Closed

Add release detail page #2807

nlhkabu opened this issue Jan 18, 2018 · 8 comments · Fixed by #2879
Assignees

Comments

@nlhkabu
Copy link
Contributor

nlhkabu commented Jan 18, 2018

We need to add a release detail page and link to it from the releases page

The release detail page should display:

  • the files for a release and a journal for the release
  • the ability to delete a release

In warehouse/templates/manage/project.html we have two links to this page:

  1. via the version number on the left of the table
  2. via the 'edit' button in the dropdown

screenshot from 2018-01-17 06-57-12

These are currently commented out in the code. We should enable them as part of this issue.

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Jan 18, 2018

A sub ticket of #424

@di di self-assigned this Jan 18, 2018
@di
Copy link
Member

di commented Jan 29, 2018

@nlhkabu I pushed a branch which stubs out the individual release view here: https://github.com/pypa/warehouse/tree/individual-release-view

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Jan 31, 2018

Thanks @di :) I started work on this - however, I don't seem to be able to output the files associated with a release. {{ release.files }} is returning a database query:

screenshot from 2018-01-31 21-37-54

I assume this means we need to pass files explicitly via the view?

I am also going to need to list the journal entries for the release - like this:

screenshot from 2018-01-31 21-37-45

Would it be possible if you made both of these data available to the template?

@di
Copy link
Member

di commented Jan 31, 2018

@nlhkabu I pushed a commit to the branch which adds the release's files to the view.

The journal entries in that screenshot are for the entire project, not for individual releases. I think we probably want a separate page (maybe something called "Events" or "Project History") at the top level rather than including them here.

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Jan 31, 2018

thank you :)

Let's open a new ticket for the project history - I believe @ewdurbin and I discussed the MVP having these displayed at a release level, but I might be mistaken on that.

@di
Copy link
Member

di commented Jan 31, 2018

Hmm, looks like I'm wrong -- legacy PyPI actually does show a mix of project-level journal entries and release-level journal entries on each release page.

This seems like it would be somewhat confusing to users. IMO it'd be better to have all the journal entries in one place, but perhaps I'm missing something obvious and @ewdurbin can chime in and explain why it's like that on legacy.

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Jan 31, 2018

thanks @di - I opened a new ticket for this - I've copied your comment over :)

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Feb 2, 2018

hi @di - I just noticed I am getting a 404 page when clicking on the 'collaborators' page from the release detail page. As far as I can tell, all other pages are working as expected. Could you please take a look? Thanks!

@nlhkabu nlhkabu mentioned this issue Feb 5, 2018
7 tasks
@di di closed this as completed in #2879 Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants