-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release detail page #2807
Comments
A sub ticket of #424 |
@nlhkabu I pushed a branch which stubs out the individual release view here: https://github.com/pypa/warehouse/tree/individual-release-view |
Thanks @di :) I started work on this - however, I don't seem to be able to output the files associated with a release. I assume this means we need to pass files explicitly via the view? I am also going to need to list the journal entries for the release - like this: Would it be possible if you made both of these data available to the template? |
@nlhkabu I pushed a commit to the branch which adds the release's files to the view. The journal entries in that screenshot are for the entire project, not for individual releases. I think we probably want a separate page (maybe something called "Events" or "Project History") at the top level rather than including them here. |
thank you :) Let's open a new ticket for the project history - I believe @ewdurbin and I discussed the MVP having these displayed at a release level, but I might be mistaken on that. |
Hmm, looks like I'm wrong -- legacy PyPI actually does show a mix of project-level journal entries and release-level journal entries on each release page. This seems like it would be somewhat confusing to users. IMO it'd be better to have all the journal entries in one place, but perhaps I'm missing something obvious and @ewdurbin can chime in and explain why it's like that on legacy. |
thanks @di - I opened a new ticket for this - I've copied your comment over :) |
hi @di - I just noticed I am getting a 404 page when clicking on the 'collaborators' page from the release detail page. As far as I can tell, all other pages are working as expected. Could you please take a look? Thanks! |
We need to add a release detail page and link to it from the releases page
The release detail page should display:
In
warehouse/templates/manage/project.html
we have two links to this page:These are currently commented out in the code. We should enable them as part of this issue.
The text was updated successfully, but these errors were encountered: