-
Notifications
You must be signed in to change notification settings - Fork 1k
Individual release view #2879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Individual release view #2879
Conversation
@nlhkabu I think everything you have in the table should probably stay. I'm not really sure how users are using the "Comment" field for a release, it's optional and there's no limit on length, so it's possible it could be quite long but in my experience it's mostly unused. Maybe we could remove the column and add some kind of a sub-row if the release has a comment?
Not sure this is necessary, a user will probably only want to delete a single file, or an entire release. |
f58d986
to
f9ee018
Compare
@nlhkabu I fixed the collaboration 404 and hooked up the 'delete release' modal. I'm seeing an issue where the modal doesn't dismiss when there is an error, could you take a look? Still need to hook up individual file deletion. |
f9ee018
to
a39a9da
Compare
@nlhkabu I hooked up individual file deletion as well, back to you! |
fyi @di - I've again made the error messages more explicit, e.g. I will look into why the modals are staying open now :) |
Oops, did I merge over this? Apologies if I did! |
@@ -117,7 +117,7 @@ <h3>Delete Release</h3> | |||
|
|||
<div id="delete-release-modal" class="modal"> | |||
<div class="modal__content" role="dialog"> | |||
<form method="POST" class="modal__form"> | |||
<form method="POST" class="modal__form" action="{{ request.route_path('manage.project.release', project_name=project.name, version=release.version) }}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha! This makes sense. We can use action="{{ request.current_route_path() }}"
here instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated, thanks :)
3879df2
to
09142ac
Compare
30c3e34
to
e2184ef
Compare
Hi @di - this should be ready for final review and merge :) |
e2184ef
to
0a4a649
Compare
0a4a649
to
15c018a
Compare
Fixes #424, fixes #2807, fixes #2808.
TODO:
Add 'delete all files' shortcut (?)