Individual release view

tests/unit/manage/test_views.py

@@ -208,6 +208,297 @@ def test_manage_project_releases(self):
         }
 
 
+class TestManageProjectRelease:
+
+    def test_manage_project_release(self):
+        files = pretend.stub()
+        project = pretend.stub()
+        release = pretend.stub(
+            project=project,
+            files=pretend.stub(all=lambda: files),
+        )
+        request = pretend.stub()
+        view = views.ManageProjectRelease(release, request)
+
+        assert view.manage_project_release() == {
+            'project': project,
+            'release': release,
+            'files': files,
+        }
+
+    def test_delete_project_release(self, monkeypatch):
+        release = pretend.stub(
+            version='1.2.3',
+            project=pretend.stub(name='foobar'),
+        )
+        request = pretend.stub(
+            POST={'confirm_version': release.version},
+            method="POST",
+            db=pretend.stub(
+                delete=pretend.call_recorder(lambda a: None),
+                add=pretend.call_recorder(lambda a: None),
+            ),
+            route_path=pretend.call_recorder(lambda *a, **kw: '/the-redirect'),
+            session=pretend.stub(
+                flash=pretend.call_recorder(lambda *a, **kw: None)
+            ),
+            user=pretend.stub(),
+            remote_addr=pretend.stub(),
+        )
+        journal_obj = pretend.stub()
+        journal_cls = pretend.call_recorder(lambda **kw: journal_obj)
+        monkeypatch.setattr(views, 'JournalEntry', journal_cls)
+
+        view = views.ManageProjectRelease(release, request)
+
+        result = view.delete_project_release()
+
+        assert isinstance(result, HTTPSeeOther)
+        assert result.headers["Location"] == "/the-redirect"
+
+        assert request.db.delete.calls == [pretend.call(release)]
+        assert request.db.add.calls == [pretend.call(journal_obj)]
+        assert journal_cls.calls == [
+            pretend.call(
+                name=release.project.name,
+                action="remove",
+                version=release.version,
+                submitted_by=request.user,
+                submitted_from=request.remote_addr,
+            ),
+        ]
+        assert request.session.flash.calls == [
+            pretend.call(
+                f"Successfully deleted release {release.version!r}.",
+                queue="success",
+            )
+        ]
+        assert request.route_path.calls == [
+            pretend.call(
+                'manage.project.releases',
+                project_name=release.project.name,
+            )
+        ]
+
+    def test_delete_project_release_no_confirm(self):
+        release = pretend.stub(
+            version='1.2.3',
+            project=pretend.stub(name='foobar'),
+        )
+        request = pretend.stub(
+            POST={'confirm_version': ''},
+            method="POST",
+            db=pretend.stub(delete=pretend.call_recorder(lambda a: None)),
+            route_path=pretend.call_recorder(lambda *a, **kw: '/the-redirect'),
+            session=pretend.stub(
+                flash=pretend.call_recorder(lambda *a, **kw: None)
+            ),
+        )
+        view = views.ManageProjectRelease(release, request)
+
+        result = view.delete_project_release()
+
+        assert isinstance(result, HTTPSeeOther)
+        assert result.headers["Location"] == "/the-redirect"
+
+        assert request.db.delete.calls == []
+        assert request.session.flash.calls == [
+            pretend.call(
+                "Must confirm the request.", queue='error'
+            )
+        ]
+        assert request.route_path.calls == [
+            pretend.call(
+                'manage.project.release',
+                project_name=release.project.name,
+                version=release.version,
+            )
+        ]
+
+    def test_delete_project_release_bad_confirm(self):
+        release = pretend.stub(
+            version='1.2.3',
+            project=pretend.stub(name='foobar'),
+        )
+        request = pretend.stub(
+            POST={'confirm_version': 'invalid'},
+            method="POST",
+            db=pretend.stub(delete=pretend.call_recorder(lambda a: None)),
+            route_path=pretend.call_recorder(lambda *a, **kw: '/the-redirect'),
+            session=pretend.stub(
+                flash=pretend.call_recorder(lambda *a, **kw: None)
+            ),
+        )
+        view = views.ManageProjectRelease(release, request)
+
+        result = view.delete_project_release()
+
+        assert isinstance(result, HTTPSeeOther)
+        assert result.headers["Location"] == "/the-redirect"
+
+        assert request.db.delete.calls == []
+        assert request.session.flash.calls == [
+            pretend.call(
+                "Could not delete release - " +
+                f"'invalid' is not the same as {release.version!r}",
+                queue="error",
+            )
+        ]
+        assert request.route_path.calls == [
+            pretend.call(
+                'manage.project.release',
+                project_name=release.project.name,
+                version=release.version,
+            )
+        ]
+
+    def test_delete_project_release_file(self, monkeypatch):
+        release_file = pretend.stub(
+            filename='foo-bar.tar.gz',
+            id=str(uuid.uuid4()),
+        )
+        release = pretend.stub(
+            version='1.2.3',
+            project=pretend.stub(name='foobar'),
+        )
+        request = pretend.stub(
+            POST={
+                'confirm_filename': release_file.filename,
+                'file_id': release_file.id,
+            },
+            method="POST",
+            db=pretend.stub(
+                delete=pretend.call_recorder(lambda a: None),
+                add=pretend.call_recorder(lambda a: None),
+                query=lambda a: pretend.stub(
+                    filter=lambda *a: pretend.stub(one=lambda: release_file),
+                ),
+            ),
+            route_path=pretend.call_recorder(lambda *a, **kw: '/the-redirect'),
+            session=pretend.stub(
+                flash=pretend.call_recorder(lambda *a, **kw: None)
+            ),
+            user=pretend.stub(),
+            remote_addr=pretend.stub(),
+        )
+        journal_obj = pretend.stub()
+        journal_cls = pretend.call_recorder(lambda **kw: journal_obj)
+        monkeypatch.setattr(views, 'JournalEntry', journal_cls)
+
+        view = views.ManageProjectRelease(release, request)
+
+        result = view.delete_project_release_file()
+
+        assert isinstance(result, HTTPSeeOther)
+        assert result.headers["Location"] == "/the-redirect"
+
+        assert request.session.flash.calls == [
+            pretend.call(
+                f"Successfully deleted file {release_file.filename!r}.",
+                queue="success",
+            )
+        ]
+        assert request.db.delete.calls == [pretend.call(release_file)]
+        assert request.db.add.calls == [pretend.call(journal_obj)]
+        assert journal_cls.calls == [
+            pretend.call(
+                name=release.project.name,
+                action=f"remove file {release_file.filename}",
+                version=release.version,
+                submitted_by=request.user,
+                submitted_from=request.remote_addr,
+            ),
+        ]
+        assert request.route_path.calls == [
+            pretend.call(
+                'manage.project.release',
+                project_name=release.project.name,
+                version=release.version,
+            )
+        ]
+
+    def test_delete_project_release_file_no_confirm(self):
+        release = pretend.stub(
+            version='1.2.3',
+            project=pretend.stub(name='foobar'),
+        )
+        request = pretend.stub(
+            POST={'confirm_filename': ''},
+            method="POST",
+            db=pretend.stub(delete=pretend.call_recorder(lambda a: None)),
+            route_path=pretend.call_recorder(lambda *a, **kw: '/the-redirect'),
+            session=pretend.stub(
+                flash=pretend.call_recorder(lambda *a, **kw: None)
+            ),
+        )
+        view = views.ManageProjectRelease(release, request)
+
+        result = view.delete_project_release_file()
+
+        assert isinstance(result, HTTPSeeOther)
+        assert result.headers["Location"] == "/the-redirect"
+
+        assert request.db.delete.calls == []
+        assert request.session.flash.calls == [
+            pretend.call(
+                "Must confirm the request.", queue='error'
+            )
+        ]
+        assert request.route_path.calls == [
+            pretend.call(
+                'manage.project.release',
+                project_name=release.project.name,
+                version=release.version,
+            )
+        ]
+
+    def test_delete_project_release_file_bad_confirm(self):
+        release_file = pretend.stub(
+            filename='foo-bar.tar.gz',
+            id=str(uuid.uuid4()),
+        )
+        release = pretend.stub(
+            version='1.2.3',
+            project=pretend.stub(name='foobar'),
+        )
+        request = pretend.stub(
+            POST={'confirm_filename': 'invalid'},
+            method="POST",
+            db=pretend.stub(
+                delete=pretend.call_recorder(lambda a: None),
+                query=lambda a: pretend.stub(
+                    filter=lambda *a: pretend.stub(one=lambda: release_file),
+                ),
+            ),
+            route_path=pretend.call_recorder(lambda *a, **kw: '/the-redirect'),
+            session=pretend.stub(
+                flash=pretend.call_recorder(lambda *a, **kw: None)
+            ),
+        )
+        view = views.ManageProjectRelease(release, request)
+
+        result = view.delete_project_release_file()
+
+        assert isinstance(result, HTTPSeeOther)
+        assert result.headers["Location"] == "/the-redirect"
+
+        assert request.db.delete.calls == []
+        assert request.session.flash.calls == [
+            pretend.call(
+                "Could not delete file - " +
+                f"'invalid' is not the same as {release_file.filename!r}",
+                queue="error",
+            )
+        ]
+        assert request.route_path.calls == [
+            pretend.call(
+                'manage.project.release',
+                project_name=release.project.name,
+                version=release.version,
+            )
+        ]
+
+
 class TestManageProjectRoles:
 
     def test_get_manage_project_roles(self, db_request):

tests/unit/packaging/test_models.py

@@ -254,6 +254,28 @@ def test_urls(self, db_session, home_page, download_url, project_urls,
         # TODO: It'd be nice to test for the actual ordering here.
         assert dict(release.urls) == dict(expected)
 
+    def test_acl(self, db_session):
+        project = DBProjectFactory.create()
+        owner1 = DBRoleFactory.create(project=project)
+        owner2 = DBRoleFactory.create(project=project)
+        maintainer1 = DBRoleFactory.create(
+            project=project,
+            role_name="Maintainer",
+        )
+        maintainer2 = DBRoleFactory.create(
+            project=project,
+            role_name="Maintainer",
+        )
+        release = DBReleaseFactory.create(project=project)
+
+        assert release.__acl__() == [
+            (Allow, "group:admins", "admin"),
+            (Allow, str(owner1.user.id), ["manage", "upload"]),
+            (Allow, str(owner2.user.id), ["manage", "upload"]),
+            (Allow, str(maintainer1.user.id), ["upload"]),
+            (Allow, str(maintainer2.user.id), ["upload"]),
+        ]
+
 
 class TestFile:
 

tests/unit/test_routes.py

@@ -168,6 +168,13 @@ def add_policy(name, filename):
             traverse="/{project_name}",
             domain=warehouse,
         ),
+        pretend.call(
+            "manage.project.release",
+            "/manage/project/{project_name}/release/{version}/",
+            factory="warehouse.packaging.models:ProjectFactory",
+            traverse="/{project_name}/{version}",
+            domain=warehouse,
+        ),
         pretend.call(
             "manage.project.roles",
             "/manage/project/{project_name}/collaboration/",