Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump pyjwt[crypto] from 2.8.0 to 2.9.0 #16378

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 2, 2024

Bumps pyjwt[crypto] from 2.8.0 to 2.9.0.

Release notes

Sourced from pyjwt[crypto]'s releases.

2.9.0

What's Changed

New Contributors

Full Changelog: jpadilla/pyjwt@2.8.0...2.9.0

Changelog

Sourced from pyjwt[crypto]'s changelog.

v2.9.0 <https://github.com/jpadilla/pyjwt/compare/2.8.0...2.9.0>__

Changed


- Drop support for Python 3.7 (EOL) by @hugovk in `[#910](https://github.com/jpadilla/pyjwt/issues/910) <https://github.com/jpadilla/pyjwt/pull/910>`__
- Allow JWT issuer claim validation to accept a list of strings too by @mattpollak in `[#913](https://github.com/jpadilla/pyjwt/issues/913) <https://github.com/jpadilla/pyjwt/pull/913>`__

Fixed


- Fix unnecessary string concatenation by @sirosen in `[#904](https://github.com/jpadilla/pyjwt/issues/904) &lt;https://github.com/jpadilla/pyjwt/pull/904&gt;`__
- Fix docs for ``jwt.decode_complete`` to include ``strict_aud`` option by @woodruffw in `[#923](https://github.com/jpadilla/pyjwt/issues/923) &lt;https://github.com/jpadilla/pyjwt/pull/923&gt;`__
- Fix docs step by @jpadilla in `[#950](https://github.com/jpadilla/pyjwt/issues/950) &lt;https://github.com/jpadilla/pyjwt/pull/950&gt;`__
- Fix: Remove an unused variable from example code block by @kenkoooo in `[#958](https://github.com/jpadilla/pyjwt/issues/958) &lt;https://github.com/jpadilla/pyjwt/pull/958&gt;`__

Added

  • Add support for Python 3.12 by @​hugovk in [#910](https://github.com/jpadilla/pyjwt/issues/910) &lt;https://github.com/jpadilla/pyjwt/pull/910&gt;__
  • Improve performance of is_ssh_key + add unit test by @​bdraco in [#940](https://github.com/jpadilla/pyjwt/issues/940) &lt;https://github.com/jpadilla/pyjwt/pull/940&gt;__
  • Allow jwt.decode() to accept a PyJWK object by @​luhn in [#886](https://github.com/jpadilla/pyjwt/issues/886) &lt;https://github.com/jpadilla/pyjwt/pull/886&gt;__
  • Make algorithm_name attribute available on PyJWK by @​luhn in [#886](https://github.com/jpadilla/pyjwt/issues/886) &lt;https://github.com/jpadilla/pyjwt/pull/886&gt;__
  • Raise InvalidKeyError on invalid PEM keys to be compatible with cryptography 42.x.x by @​CollinEMac in [#952](https://github.com/jpadilla/pyjwt/issues/952) &lt;https://github.com/jpadilla/pyjwt/pull/952&gt;__
  • Raise an exception when required cryptography dependency is missing by @​tobloef in &lt;https://github.com/jpadilla/pyjwt/pull/963&gt;__
Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner August 2, 2024 09:41
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Aug 2, 2024
@dependabot dependabot bot force-pushed the dependabot/pip/pyjwt-crypto--2.9.0 branch 2 times, most recently from 06046b6 to dfe8781 Compare August 6, 2024 09:17
@miketheman
Copy link
Member

Failure:

___________ TestPyJWTBackstop.test_decodes_token_typeerror_on_pyjwk ____________
[gw0] linux -- Python 3.12.4 /opt/warehouse/bin/python

self = <tests.unit.oidc.test_services.TestPyJWTBackstop object at 0xffd08f7fc1d0>

    def test_decodes_token_typeerror_on_pyjwk(self):
        privkey_jwk = PyJWK.from_json(algorithms.RSAAlgorithm.to_jwk(self._privkey))
        pubkey_jwk = PyJWK.from_json(algorithms.RSAAlgorithm.to_jwk(self._pubkey))
    
        token = jwt.encode({"foo": "bar"}, privkey_jwk.key, algorithm="RS256")
    
        # Passing a `PyJWK` directly into `jwt.decode` does not work.
>       with pytest.raises(TypeError, match=r"Expecting a PEM-formatted key\."):
E       Failed: DID NOT RAISE <class 'TypeError'>

tests/unit/oidc/test_services.py:[98](https://github.com/pypi/warehouse/actions/runs/10056636776/job/27795874529?pr=16239#step:5:99)2: Failed

Looks like the upstream enabled passing PyJWK now. Refs: jpadilla/pyjwt#886

@woodruffw Should we be able to update the tests to allow passing a PyJWK now that the underlying library allows for it?

@miketheman miketheman added the blocked Issues we can't or shouldn't get to yet label Aug 6, 2024
@woodruffw
Copy link
Member

@woodruffw Should we be able to update the tests to allow passing a PyJWK now that the underlying library allows for it?

Yep! That test is a backstop to allow us to catch when this behavior changed, which we expected it to 🙂 -- we can now invert that test IMO.

@miketheman
Copy link
Member

@dependabot rebase

Bumps [pyjwt[crypto]](https://github.com/jpadilla/pyjwt) from 2.8.0 to 2.9.0.
- [Release notes](https://github.com/jpadilla/pyjwt/releases)
- [Changelog](https://github.com/jpadilla/pyjwt/blob/master/CHANGELOG.rst)
- [Commits](jpadilla/pyjwt@2.8.0...2.9.0)

---
updated-dependencies:
- dependency-name: pyjwt[crypto]
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/pyjwt-crypto--2.9.0 branch from dfe8781 to ac97960 Compare August 7, 2024 18:21
As updated in jpadilla/pyjwt#886

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@miketheman miketheman merged commit a75c68c into main Aug 7, 2024
17 checks passed
@miketheman miketheman deleted the dependabot/pip/pyjwt-crypto--2.9.0 branch August 7, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Issues we can't or shouldn't get to yet dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants