-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External classifiers #7582
Merged
Merged
External classifiers #7582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merwok
reviewed
Mar 24, 2020
di
force-pushed
the
external-classifiers
branch
from
March 24, 2020 22:51
9370491
to
5f7730d
Compare
Need to merge/release pypa/trove-classifiers#6 and update this here first, and waiting on a review from @ewdurbin at least (although we've chatted about it and I don't think there's much else to do here). |
ewdurbin
approved these changes
Apr 3, 2020
Just out of an abundance of caution, I'm gonna snag a backup of the classifiers table before this merges. :-D Otherwise, 💯 |
Backup taken! |
This was referenced Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the canonical source for classifiers out of PyPI's database and into the
trove-classifiers
project.This is a necessary step to resolve pypa/packaging#147 and move PyPI's metadata validation out of PyPI and into
packaging
.PyPI's behavior here for the end user remains unchanged. For administrators, new & deprecated classifiers are no longer created through the UI, but as pull requests for
trove-classifiers
and dependency upgrades here.PyPI still retains a
Classifier
model to help with efficiently searching for projects based on classifiers, but it is now essentially just a mapping from the classifier name to id. New rows in the classifiers table are created for new classifiers the first time a project is uploaded using that classifier.Fixes #4626, fixes #3786, closes #4950, closes #1244.