Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "how to request a trove classifier change" help #7463

Closed
story645 opened this issue Feb 28, 2020 · 5 comments · Fixed by #7735
Closed

Update "how to request a trove classifier change" help #7463

story645 opened this issue Feb 28, 2020 · 5 comments · Fixed by #7735
Labels
bug 🐛 documentation good first issue This issue is ideal for first-time contributors! help needed We'd love volunteers to advise on or help fix/implement this. HTML requires change to HTML files

Comments

@story645
Copy link

story645 commented Feb 28, 2020

Describe the bug
The link in https://pypi.org/help/#new-classifier to trigger a new trove classifier yields an empty template opened on warehouse:
image

Expected behavior

  1. The template should have the following fields since this is what's always requested:
    • name of the requested classifier
    • a brief justification of why it is important.
  2. the issue should probably be opened on pypi-support since that's where the issue is immediately moved to

To Reproduce
https://github.com/pypa/warehouse/issues/new?title=Request+trove+classifier&template=new-trove-classifier.md

attn: @brainwane xref: #3231

@di
Copy link
Member

di commented Feb 28, 2020

We moved the repo for these requests, it should link to https://github.com/pypa/pypi-support/issues/new?labels=classifier+request&template=new-trove-classifier.md&title=Trove+Classifier+Request instead.

@di di added bug 🐛 good first issue This issue is ideal for first-time contributors! HTML requires change to HTML files labels Feb 28, 2020
@di
Copy link
Member

di commented Mar 26, 2020

Once #7582 is merged, we'll actually want to update this to direct users to create a PR at https://github.com/pypa/trove-classifiers instead.

@di di added the blocked Issues we can't or shouldn't get to yet label Mar 26, 2020
@pradyunsg
Copy link
Contributor

@di Any reason to not start redirecting requests to that repository already? Given that there's concensus already that we'd want to switch to using the library in warehouse.

@di
Copy link
Member

di commented Mar 26, 2020

Yeah, I'd like to at least get some reviews on #7582 first, to make sure that's headed in the right direction.

@brainwane
Copy link
Contributor

Now that we have merged #7582 I do think redirecting requests to https://github.com/pypa/trove-classifiers is the right move (plus updating https://pypi.org/help/#new-classifier ).

@brainwane brainwane changed the title Request Trove Classifier Template Update "how to request a trove classifier change" help Apr 3, 2020
@brainwane brainwane added documentation help needed We'd love volunteers to advise on or help fix/implement this. and removed blocked Issues we can't or shouldn't get to yet labels Apr 3, 2020
di added a commit that referenced this issue Apr 4, 2020
@di di closed this as completed in #7735 Apr 4, 2020
di added a commit that referenced this issue Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 documentation good first issue This issue is ideal for first-time contributors! help needed We'd love volunteers to advise on or help fix/implement this. HTML requires change to HTML files
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants