Fix a scatter eager_subs issue #517
Conversation
funsor/terms.py
Outdated
| new_subs = [] | ||
| for name, sub in self.subs: | ||
| if name in subs: | ||
| assert isinstance(subs[name], Variable) |
There was a problem hiding this comment.
Remove this assertation seem to resolve the Slice substitution issue
(there is another issue happens in test_scan_hmm that @_get_support_value.register(funsor.cnf.Contraction) couldn't extract the delta_terms - but I guess that issue is not related to this)
There was a problem hiding this comment.
Hmm, I guess what's happening is that there can be bound variables of Scatter that share names with the fresh variables, and we need to implement a better _alpha_convert method that properly handles this case. Rather than just removing the assertion, does changing this to
if name in subs and isinstance(subs[name], Variable):
new_subs.append((subs[name].name, sub))fix the downstream error with Slice? It's still not correct in general, but it might be enough to unblock you.
There was a problem hiding this comment.
Yes, it does resolving the Slice issue (but the test still fails by the _get_support_value issue mentioned above).
Pair-coded with @eb8680 @fritzo @ordabayevy
This bug is detected while running a test for infer_discrete with NumPyro scan