Make infer_discrete work with scan #991
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzo
reviewed
Apr 16, 2021
numpyro/contrib/funsor/discrete.py
Outdated
|
|
||
| with approx: | ||
| approx_factors = funsor.adjoint.adjoint(sum_op, prod_op, log_prob) | ||
| approx_factors = tape.adjoint(sum_op, prod_op, log_prob) |
There was a problem hiding this comment.
this is the line where Scatter and Deltas are introduced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue of #977. Pair-coded with @eb8680 @fritzo @ordabayevy
TODO
enum_scan: underenum, latent variable names will be_PREV_zandzwhile without it, there is only one latent variable namesz. One solution is to merge_PREV_zandzininfer_discreteFollow-up PR: add test for history > 1
Blocked by pyro-ppl/funsor#517