-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hamiltonian Monte Carlo with Energy Conserving Subsampling #905
Conversation
new problem stuff being 1D (precision)
Added dataset
working with hierarchical priors
Lots of things to do
missing tests
I think we can test if |
@fehiepsi those tests sound good. I'll add them in. |
@fehiepsi should the python version in CI be bumped to 3.9? looks like it's supported by Github Actions. |
It is not needed. We typically want to test for the oldest Python version that we support. |
…nd changed Norm-Norm to 3-dim latent param.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean to me! Thanks for addressing my comments, @OlaRonning! Please let me know if you want to add more tests in another PR or if this is ready to merge when the following comments are addressed.
Hi @fehiepsi, thanks for the reviews! I'll add the test cases (proxy result and low variance) you suggested and then it's ready to be merged. |
…ert variance on difference between sub and all.
Introduces HMCECS to numpyro.
This PR includes: