Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hamiltonian Monte Carlo with Energy Conserving Subsampling #905
Hamiltonian Monte Carlo with Energy Conserving Subsampling #905
Changes from 85 commits
4321595
b8001a9
26219ce
9a326db
44d2fc1
4eeb1f0
ca9dece
f01c027
cc2f1b0
c3de253
b17d53d
40be6c3
f58dbf7
3a25523
a075857
b40f662
54bca12
765b3d6
1fc6740
3993afd
9dd7025
bdcd352
742162c
81b8956
ffbaa9e
1e83bb7
3f918ed
9fc0f3f
24e1c1b
4243abe
f996d18
1095f19
0c18026
d04f651
b8f8830
65531c2
216c2cf
d6e6700
c59b317
dafaa6e
243e7bc
c4252bb
20b7350
4d7e4ed
f867af1
89c8ffe
1403dfe
1c6af82
2a8cc23
7c41cee
6f1f222
dd0426c
60e0912
85957dc
c01738f
2151895
82ef761
e46cb40
5b8af6e
41bda0c
ab7888e
a9d2c0e
e4bf263
508e96a
3761905
a695046
896cd19
4e9a192
f5e8894
b571228
7d9cd11
5dbac85
bb783f8
7644a08
a997acb
ad2f799
fb95035
e1150ea
c0a1c4c
5583162
8e08d76
48cd7ef
ff28eb0
5febf7e
2c26173
6359292
0b886d7
469a1f2
0fb8d01
5a6f629
29f3708
2aef856
cc2669e
63323ec
89a99a2
0131f3e
c697e91
400389f
2e1dddb
6474df3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this TODO mean there is a bug here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think this is necessary as the constraint on
self.scale
is already positive. @LysSanzMoreta let me know if you disagree.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this TODO too. I think the math here is right.