Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

240 review nncell and nncombinatorial models + Fixed SAN bugs #268

Closed
wants to merge 6 commits into from

Conversation

gbg141
Copy link
Member

@gbg141 gbg141 commented Feb 15, 2024

This pull request addresses the following points:

  • Refactorization of cell and combinatorial models, decoupling the readout function from them (analogous to what was already implemented for simplicial and hypergraph architectures, PRs Simplicial checks #250 and Hypergraph checks #249)
  • Solved two bugs in SAN implementation --it was not possible to train it on GPU.
  • Added __init__ as an excluding method for numpydoc_validation; currently no class in TopoModelX document them, as it was previously excluded when using isort and flake8.

@gbg141 gbg141 requested review from ninamiolane and mhajij February 15, 2024 20:29
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@gbg141
Copy link
Member Author

gbg141 commented Feb 15, 2024

Working on solving the tests!

@gbg141 gbg141 marked this pull request as draft February 15, 2024 20:39
@gbg141 gbg141 closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant