Simplicial checks #250
Merged
Simplicial checks #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
==========================================
+ Coverage 96.54% 97.49% +0.94%
==========================================
Files 58 58
Lines 2229 2155 -74
==========================================
- Hits 2152 2101 -51
+ Misses 77 54 -23
☔ View full report in Codecov by Sentry. |
ninamiolane
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
LGTM! Just one comment: is there a reason to have a file path data/cora/Cora/raw?
- there is no uppercase in python, thus it should be at least
data/cora/cora/raw - however, the most straightforward is:
data/cora
Are you using this complicated path for consistency with how this dataset is refered to in other packages?
In any case, I'm merging this PR now (so that we avoid github conflicts), but if it makes sense to update the file path to data/cora, could you do it in a follow-up PR? Thanks!
This was referenced Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces some modifications in simplicial models to ensure a consistent implementation across all of them (with the exceptions of
SCA_CMPSandSCConv, that need further analysis).In particular, we decoupled the readout from the models, thus making a uniform implementation of the simplicial architectures for whichever dowstream task is considered. The output of each model is now the set of final hidden representations of the involved simplices (nodes, edgees, faces,... or a combination of them), and then a light
Networkclass is defined in the tutorials to leverage the final hidden states to get the desired output for the considered dataset and task.Apart from this refactorization of the implementations, which could facilitate the aplication/adaptation of the models to different domains and tasks, we have also checked the model pipelines, as well as updated the involved test files accordingly (except with
SCA_CMPSandSCConv, which require a closer look).