240 review nncell and nncombinatorial models + Fixed SAN bugs #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
==========================================
- Coverage 97.45% 97.40% -0.05%
==========================================
Files 58 58
Lines 2120 2084 -36
==========================================
- Hits 2066 2030 -36
Misses 54 54 ☔ View full report in Codecov by Sentry. |
ffl096
requested changes
Feb 16, 2024
pyproject.toml
Outdated
Comment on lines
124
to
128
| exclude = [ | ||
| '\.undocumented_method$', | ||
| '\.__repr__$', | ||
| '\.__init__$', | ||
| ] |
There was a problem hiding this comment.
Please revert this, __init__ and __repr__ should be documented.
There was a problem hiding this comment.
I have reverted it, but currently __init__ methods are not documented in TopoModelX. This results in failing the tests for any class that you modify.
ffl096
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the following points: