Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Input Logic of Cell Complex Models #273

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

gbg141
Copy link
Member

@gbg141 gbg141 commented Apr 4, 2024

This pull request aims to update the input logic of cell complex models by

  • unifying the nomenclature of connectivity matrices across the different models, in accordance to TopoNetX library (i.e. adjacency_r, incidence_r, down_laplacian_r, etc.);
  • adding **kwargs optional parameter to models and layers, hence allowing the flexibility to modify additional parameters of the model's inner layers (standard practice in other libraries such as torch_geometric).

Upon acceptance of these changes, similar modifications will be applied to Hypergraph, Simplicial, and Combinatorial models.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.37%. Comparing base (8ea75a7) to head (db96096).

Files Patch % Lines
topomodelx/nn/cell/can.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   97.36%   97.37%           
=======================================
  Files          58       58           
  Lines        2050     2054    +4     
=======================================
+ Hits         1996     2000    +4     
  Misses         54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you very much for this! Green light to update the other files for consistency with toponetx.

@ninamiolane ninamiolane merged commit c349941 into main Apr 8, 2024
23 of 24 checks passed
@ninamiolane ninamiolane deleted the cell_models_input_logic branch April 8, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants