Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Input Logic of Hypergraph Models #274

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

gbg141
Copy link
Member

@gbg141 gbg141 commented Apr 12, 2024

Following PR #273 , this pull request checks the input nomenclature among hypergraph models and adds the **kwargs optional parameter to both models and layers. Additionally, bits of documentation have been added and/or modified to pass the new numpydoc_validation tests.

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (c349941) to head (74b77e4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #274   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files          58       58           
  Lines        2054     2054           
=======================================
  Hits         2000     2000           
  Misses         54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you so much for bringing our codebase into this much nicer state!

@ninamiolane ninamiolane merged commit 2267768 into main Apr 12, 2024
24 checks passed
@ninamiolane ninamiolane deleted the hypergraph_models_input_logic branch April 12, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants