Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort icons inverted in next-gen branch #671

Closed
harmin-parra opened this issue May 10, 2023 · 4 comments
Closed

Sort icons inverted in next-gen branch #671

harmin-parra opened this issue May 10, 2023 · 4 comments

Comments

@harmin-parra
Copy link
Contributor

Issue observed in v4.0.0rc, next-gen branch

When the sort is ascending, the icon is a downwards triangle.
When the sort is descending, the icon is a upwards triangle.

The sort icons are inverted in regard to the current behavior in v3.2.0

@BeyondEvil
Copy link
Contributor

Like I said in the PR, is there some convention we can rely on? Maybe the current way is correct and the old way was incorrect?

@harmin-parra
Copy link
Contributor Author

I guess such convention or standard doesn't exist.
Maybe I was used to the old style :)

@BeyondEvil
Copy link
Contributor

I'm not saying you're wrong and it probably makes sense to have it "the old way".

I was mostly curious if a convention existed.

@BeyondEvil
Copy link
Contributor

BeyondEvil pushed a commit that referenced this issue May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants