Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for #671 - Sort icons inverted in next-gen branch #672

Merged
merged 1 commit into from
May 11, 2023
Merged

fix for #671 - Sort icons inverted in next-gen branch #672

merged 1 commit into from
May 11, 2023

Conversation

harmin-parra
Copy link
Contributor

No description provided.

@BeyondEvil
Copy link
Contributor

Is this personal preference or is there some convention or something we can lean back on?

@BeyondEvil
Copy link
Contributor

Can you please redo these changes against the master branch.

It's probably the easiest way as the next-gen branch has been merged and many changes since has been made.

@BeyondEvil BeyondEvil changed the base branch from next-gen to master May 11, 2023 20:51
@BeyondEvil BeyondEvil self-requested a review May 11, 2023 21:04
BeyondEvil
BeyondEvil approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@BeyondEvil BeyondEvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@BeyondEvil BeyondEvil merged commit 15356c8 into pytest-dev:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeyondEvil BeyondEvil BeyondEvil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harmin-parra @BeyondEvil