[WIP] Import pluggy directly

[stephendonner]

Sorry, @davehunt - I haven't run this at all, and don't know the ramifications of this change, other than pytest has stopped vendoring pluggy as of 3.3.0 (see pytest-dev/pytest#2719). (Perhaps I should've just filed an Issue, instead.)

[stephendonner]

I filed https://github.com/davehunt/pytest-metadata/issues/5 instead/in addition - please close/comment, etc. as necessary :-)

[isaulv]

I was just going to make this change myself.
Maybe we should make it a conditional so that we don't break users of the plugin.

try:
    import pluggy
except ImportError:
   import _pytest._pluggy as pluggy

[RonnyPfannschmidt]

it should be the other way around, else it reports the wrong pytest pluggy version
for completeness it should probably report both, pytest pluggy and global pluggy

[jayant2014]

It should be like Ronny suggested.

try:
import _pytest._pluggy as pluggy
except ImportError:
import pluggy

[nicoddemus]

Also it is probably worth to add more pytest versions to tox.ini.

[davehunt]

Fixed in davehunt@4d28adc. @nicoddemus should we move this plugin to pytest-dev?

[nicoddemus]

@nicoddemus should we move this plugin to pytest-dev?

@davehunt sure thing! Do you have the necessary permissions I assume?

[davehunt]

I think only admins of pytest-dev can do that @nicoddemus. If I recall correctly when we moved my other plugins last year I transferred them to you, and you created the necessary teams according to https://docs.pytest.org/en/latest/contributing.html#submitplugin and transferred the repo to pytest-dev.

[nicoddemus]

Oh I see.

@davehunt let's proceed according to protocol then? Could you please send an email to the mailing list requesting the move? I will reply right away agreeing and once another person agrees we can go forward with the move. 👍