Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Import pluggy directly #4

Closed
wants to merge 1 commit into from
Closed

[WIP] Import pluggy directly #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pytest_metadata/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import os
import platform

import _pytest._pluggy as pluggy
import pluggy
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just going to make this change myself.
Maybe we should make it a conditional so that we don't break users of the plugin.

try:
    import pluggy
except ImportError:
   import _pytest._pluggy as pluggy

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be the other way around, else it reports the wrong pytest pluggy version
for completeness it should probably report both, pytest pluggy and global pluggy

import pytest
import py

Expand Down