Change how WebSocket urls are generated #3344
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix issues with websocket URL creation.
If endpoint had an unterminated path it would strip the last element in the path and replace it with ws, it would also downgrade wss to ws if user specifies the endpoint as wss://
Rationale
Fix bug were path was overwritten if not terminated with a / . We use a url format {protocol}://{subdomain}.{domain}.{TLD}/api={key} if this is not terminated with a / it will rewrite it too {protocol}://{subdomain}.{domain}.{TLD}/ws which results in a 403 as we can't authenticate.
Also if the uses passes a websocket address wss:// it will downgrade it to unsecure ws:// which is a potential vulnerability risk
How has this been tested?