Skip to content

Change how WebSocket urls are generated #3344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Andrew-Pohl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change how WebSocket urls are generated #3344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions price_service/client/js/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,15 @@ import type { HexString } from "@pythnetwork/price-service-sdk";
* @returns Ws(s) protocol endpoint of the same address
*/
export function makeWebsocketUrl(endpoint: string) {
const url = new URL("ws", endpoint);
const useHttps = url.protocol === "https:";
const url = new URL(endpoint);

url.protocol = useHttps ? "wss:" : "ws:";
// Switch from http/https to ws/wss, if already ws/wss do nothing
if (url.protocol === "https:") url.protocol = "wss:";
else if (url.protocol === "http:") url.protocol = "ws:";

// Ensure the pathname ends with a trailing slash and add ws
url.pathname = url.pathname.replace(/\/?$/, "/");
url.pathname = url.pathname + "ws";

return url.toString();
}
Expand Down