Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is emanspeaks/pyls-flake8 the preferred plugin for flake8 linting? #55

Closed
GerardoGR opened this issue Jul 12, 2021 · 1 comment · Fixed by #57
Closed

Is emanspeaks/pyls-flake8 the preferred plugin for flake8 linting? #55

GerardoGR opened this issue Jul 12, 2021 · 1 comment · Fixed by #57
Milestone

Comments

@GerardoGR
Copy link
Contributor

Hi 👋
From reading the 3rd-party plugins section, it seems that the preferred method to lint with flake8 is by installing the https://github.com/emanspeaks/pyls-flake8 plugin. On the other hand I see there is already a flake8 plugin in this repo: pylsp/plugins/flake8_lint.py. Which one should I use?

If the pylsp/plugins/flake8_lint.py plugin is the preferred one. I can send a PR to update the CONFIGURATION.md to enable flake8 linting, e.g:

Configuration Key Type Description Default
pylsp.plugins.flake8.enabled boolean Enable or disable the plugin. true
@krassowski
Copy link
Contributor

krassowski commented Jul 12, 2021

I don't think a motion of "preferred" plugin exist. Please note that the builtin flake8_lint.py plugin is disabled by default:

return {'plugins': {'flake8': {'enabled': False}}}

So the default value should be false. It seems that it is indeed missing from the schema.json file; please feel free to submit a PR to update the schema and update the OCNFIGURATION.md using the schema file (see https://github.com/python-lsp/python-lsp-server#development).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants