Document internal flake8 plugin schema and configuration #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krassowski
reviewed
Jul 13, 2021
krassowski
reviewed
Jul 13, 2021
GerardoGR
force-pushed
the
document-flake8-plugin
branch
from
62a1e6f
to
41b7bc6
Compare
|
@krassowski, is this one ready to merge? |
krassowski
reviewed
Jul 21, 2021
|
Yes, it looks good to me, I tested most of these config optoins locally to make sure they work. I added one suggestion for improvement (note: committing in GitHub UI is not enough, this will need regenerating the md file, I can do that) but this can be also done in follow up PR if you were aiming to get this in and cut a release now. |
krassowski
approved these changes
Jul 21, 2021
|
No worries, we need to finish #53 before making the release |
ccordoba12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note-to-self: Take more time to read the comments from the maintainers. I spent 15 mins syncing manually the
schema.jsonand theCONFIGURATION.mduntil I realized @krassowski already shared a script to do that automagically 😅# from https://github.com/python-lsp/python-lsp-server#development python scripts/jsonschema2md.py pylsp/config/schema.json CONFIGURATION.mdCloses #55