Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more installation instructions to Readme #248

Merged
merged 2 commits into from
Aug 27, 2022
Merged

Add more installation instructions to Readme #248

merged 2 commits into from
Aug 27, 2022

Conversation

nougcat
Copy link
Contributor

@nougcat nougcat commented Jul 16, 2022

Windows and Linux installation instructions are now listed in readme

Fixes #245

windows and linux installation instructions are now listed in readme
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nougcat for your help with this! I left some suggestions for you, otherwise looks good to me.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
@nougcat
Copy link
Contributor Author

nougcat commented Aug 24, 2022

Thanks for suggestions @ccordoba12 , I added all your suggestions in the commit bd67260

Also I'm sorry for not responding to you, at the time I have committed your suggestions, I'm still learning how to collaborate with people on github.

@ccordoba12 ccordoba12 added this to the v1.6.0 milestone Aug 27, 2022
@ccordoba12 ccordoba12 changed the title added more installation instructions to readme Add more installation instructions to Readme Aug 27, 2022
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your help @nougcat!

Note: The failures in our tests were fixed already in PR #258.

@ccordoba12 ccordoba12 merged commit d3f97f7 into python-lsp:develop Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add alternative ways to install python-lsp-server
2 participants