-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for EOL Python 3.5 #4746
Conversation
Not relevant for this particular PR, but two of the Docker images are using Python 3.5: I think we can can probably drop the Docker image for Xenial, we test Xenial extensively on Travis CI. (And Xenial's EOL is in April 2021, not too far off.) As for Stretch (EOL 2022), should we upgrade Python in the image? Have we done that before, or is the idea that the Docker images test the native Python only, and we can drop it? |
There are also comments in winbuild readmes
and docs
|
Thanks, updated. |
Amazon 1 and CentOS 6 run FreeType 2.3.1, and all other jobs run 2.8.x or newer. |
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
Remove requirement for Python >= 3.6
Using Python 3.6+ would allow the project to use f-strings if it is desired. IMO, f-strings tend to be nicer to read than
|
Yep, was planning on doing that in a follow up. Wanted to get this smaller one in first to make it easier to review and reduce the CI sooner. Thanks! |
Co-authored-by: nulano <nulano@nulano.eu>
@radarhere Is this okay to merge? |
Updated CI targets
cmd_set("MSSdk", "1"), # for Python 3.5 and PyPy3.6 | ||
cmd_set("MSSdk", "1"), # for PyPy3.6 | ||
cmd_set("py_vcruntime_redist", "true"), # use /MD, not /MT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to note here so I don't forget:
MSSdk
and py_vcruntime_redist
will no longer be required by PyPy in the next release.
py_vcruntime_redist
is still required by CPython 3.6, but not CPython 3.7.
Let's drop these two for now, and can consider either upgrading one from Python 3.5 to something newer, or install FreeType 2.6.1 on another CI job. More generally, we could pick a minimum version of FreeType to support. Some release dates [1] [2]:
|
Python 3.5 reaches EOL on 2020-09-13:
The next Pillow release 8.0.0 release is due out after that, on 2020-10-15 (#4764).
This removes testing for Python 3.5 on the CIs, updates docs and metadata. I'll send another PR later with syntax updates, but first it's good to reduce the CI usage to speed up PR builds.
Edit: It also removes some redundant PyPy compatibility code for old and unsupported PyPy versions.
Notes:
AppVeyor tests on two Python versions, the lowest supported (was 3.5, now 3.6) and the highest.
Travis CI and GitHub Actions tested
PYTHONOPTIMIZE=2
on the 3.5 job (andPYTHONOPTIMIZE=1
on 3.6). Now it testsPYTHONOPTIMIZE=2
on the 3.7 job.Travis CI tested
s390x
on 3.5 (chosen arbitrarily). Now testss390x
on 3.8, asarm64
is in 3.6 andppc64le
is on 3.7.