Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for PyPy3 < 7.2.0 #4964

Merged
merged 3 commits into from
Oct 12, 2020
Merged

Drop support for PyPy3 < 7.2.0 #4964

merged 3 commits into from
Oct 12, 2020

Conversation

nulano
Copy link
Contributor

@nulano nulano commented Oct 12, 2020

Is it time to remove compatibility code for PyPy3<7.2.0 released a year ago on 2019-10-14? See also #4145 (comment).

Changes proposed in this pull request:

I did not remove the distutils envars from #4746 (comment) which are no longer necessary as of 7.3.2. I think it makes sense to keep these until Python 3.6 support is dropped at which point users will have to upgrade PyPy anyway (PyPy 7.3.2 is the first to support Python 3.7).

@radarhere
Copy link
Member

A year doesn't seem very long when talking in the context of end-of-life. The more interesting thing to me is that PyPy 7.2.0 is the first to support 3.6 without the word 'beta' included as a warning.

I don't remember if this was needed on MacOS with PyPy 7.3.1 or older, but the wheels for the 8.0.0 release (#4764) should ideally (I'm assuming) target the latest 7.3.2 version.

I would have thought the wheels should target the earliest support version, rather than the latest, to ensure compatibility. But the wheels are generated at pillow-wheels, not here, so I don't think that's relevant.

@hugovk
Copy link
Member

hugovk commented Oct 12, 2020

I asked PyPy on Twitter:

@pypyproject CPython lists supported (3.6-3.9) and EOL versions:

https://devguide.python.org/#status-of-python-branches
https://devguide.python.org/devcycle/#end-of-life-branches

Does PyPy have a similar concept? Or is it just the latest release, i.e. now only PyPy 7.3.2 (for Python 2.7, 3.6, and 3.7) is supported?

https://morepypy.blogspot.com/2020/09/pypy-732-triple-release-python-27-36.html

Their reply:

It's the latter, we only really support the most current release.


I suggest in general we aim to support the latest release of PyPy?

(Excluding any Python versions that are EOL by CPython, i.e. Python 2.7.)

And as Pillow 8.0.0 is a major release, it's okay to remove old compat code?

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add to the release notes.

@hugovk hugovk merged commit c1a9f88 into python-pillow:master Oct 12, 2020
@nulano
Copy link
Contributor Author

nulano commented Oct 12, 2020

A year doesn't seem very long when talking in the context of end-of-life. The more interesting thing to me is that PyPy 7.2.0 is the first to support 3.6 without the word 'beta' included as a warning.

I seem to recall a comment from PyPy about a similar issue where they mentioned something along the lines of "... you can remove it after a year or so ..." and wanted to link to it later, but I'm having trouble finding it.

I don't remember if this was needed on MacOS with PyPy 7.3.1 or older, but the wheels for the 8.0.0 release (#4764) should ideally (I'm assuming) target the latest 7.3.2 version.

I would have thought the wheels should target the earliest support version, rather than the latest, to ensure compatibility. But the wheels are generated at pillow-wheels, not here, so I don't think that's relevant.

The relevant part is that I'm not sure if the tests can pass on 7.3.1 on MacOS, and that change is made here.

I suggest in general we aim to support the latest release of PyPy?

Makes sense to me. Additionally, 7.1.x is now two major versions behind.

@nulano nulano deleted the pypy branch October 12, 2020 17:37
@radarhere radarhere changed the title Drop support for old PyPy versions Drop support for PyPy3 < 7.2.0 Oct 13, 2020
@hugovk hugovk added Removal Removal of a feature, usually done in major releases and removed Needs Release Notes labels Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Removal Removal of a feature, usually done in major releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants