Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA: Remove obsolete code for old PyPy #4984

Merged
merged 1 commit into from
Oct 16, 2020
Merged

GHA: Remove obsolete code for old PyPy #4984

merged 1 commit into from
Oct 16, 2020

Conversation

nulano
Copy link
Contributor

@nulano nulano commented Oct 16, 2020 •
edited
Loading

Missed this as part of #4964.

The tests now pass without the workaround:
https://github.com/python-pillow/Pillow/pull/4984/checks?check_run_id=1262633517#step:27:1628

Tests/test_imagetk.py::test_kw PASSED                                    [ 94%]
Tests/test_imagetk.py::test_photoimage PASSED                            [ 94%]
Tests/test_imagetk.py::test_photoimage_blank PASSED                      [ 94%]
Tests/test_imagetk.py::test_bitmapimage PASSED                           [ 94%]

@hugovk hugovk added the automerge Automatically merge PRs that are ready label Oct 16, 2020
@nulano
Copy link
Contributor Author

nulano commented Oct 16, 2020

Travis finally finished after 4 hours! but Mergify can't actually merge this:

GitHub App like Mergify are not allowed to merge pull request where .github/workflows is changed.

@hugovk hugovk merged commit 970e862 into python-pillow:master Oct 16, 2020
@hugovk
Copy link
Member

hugovk commented Oct 16, 2020

Ah yes. Thanks!

@nulano nulano deleted the pypy branch October 16, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge PRs that are ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nulano @hugovk