-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Python 3.6 #263
Deprecate Python 3.6 #263
Conversation
f239329
to
da1f8ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tony, couple suggestions
d73e3a3
to
a3262b5
Compare
c85f92d
to
960065d
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Branch Vincent <branchevincent@gmail.com>
Co-authored-by: Branch Vincent <branchevincent@gmail.com>
Co-authored-by: Branch Vincent <branchevincent@gmail.com>
960065d
to
4bb19c9
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@neersighted can this have tests ran on them? Is it possible to allow tests to always run for me? |
in re:
@danieleades Just a rebase against master |
There is no manual whitelist. Having a merged PR will automatically run CI for you in the future. |
* Vendors: Bump min python 3.6 -> 3.7 * ci: Remove python 3.6 * ci[pre-commit]: Update pyupgrade arg 3.6 -> 3.7 * chore(flake8): Add min_python_version * deps(pyproject): Bump minimum python 3.6 -> 3.7 * deps: Remove PEP 557 (dataclasses) backport for 3.6 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * chore(tox): remove python 3.6 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * chore: Remove PY36 * CI(integration): Remove 3.6 * chore(testutils.py): Unused args Co-authored-by: Branch Vincent <branchevincent@gmail.com> * build(deps): Simplify isort markers Co-authored-by: Branch Vincent <branchevincent@gmail.com> * build(deps): Simplify pre-commit marker Co-authored-by: Branch Vincent <branchevincent@gmail.com> * chore: Cleanup unused condition, import * chore: Remove PY37 checks (unused) * chore: Fix codesmell See also: https://sonarcloud.io/project/issues?id=poetry-core&open=AX5towEhmZqnEonFAx80&pullRequest=263&resolved=false&types=CODE_SMELL * chore: Remove FileNotFoundError Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Branch Vincent <branchevincent@gmail.com>
* Vendors: Bump min python 3.6 -> 3.7 * ci: Remove python 3.6 * ci[pre-commit]: Update pyupgrade arg 3.6 -> 3.7 * chore(flake8): Add min_python_version * deps(pyproject): Bump minimum python 3.6 -> 3.7 * deps: Remove PEP 557 (dataclasses) backport for 3.6 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * chore(tox): remove python 3.6 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * chore: Remove PY36 * CI(integration): Remove 3.6 * chore(testutils.py): Unused args Co-authored-by: Branch Vincent <branchevincent@gmail.com> * build(deps): Simplify isort markers Co-authored-by: Branch Vincent <branchevincent@gmail.com> * build(deps): Simplify pre-commit marker Co-authored-by: Branch Vincent <branchevincent@gmail.com> * chore: Cleanup unused condition, import * chore: Remove PY37 checks (unused) * chore: Fix codesmell See also: https://sonarcloud.io/project/issues?id=poetry-core&open=AX5towEhmZqnEonFAx80&pullRequest=263&resolved=false&types=CODE_SMELL * chore: Remove FileNotFoundError Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Branch Vincent <branchevincent@gmail.com>
Resolves: python-poetry/poetry#4997
See also: python-poetry/poetry#5055, python-poetry/install.python-poetry.org#11
As I'm getting acclimated with the code base, this may have some back and forth to it
Later?