Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dataclasses from build-system requires #304

Merged
merged 1 commit into from
Mar 9, 2022
Merged

remove dataclasses from build-system requires #304

merged 1 commit into from
Mar 9, 2022

Conversation

abn
Copy link
Member

@abn abn commented Mar 9, 2022

With Python 3.6 deprecated in #263, the build-system.requires entries for dataclasses is not required.

@abn abn requested a review from a team March 9, 2022 16:29
@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.6% 1.6% Duplication

@finswimmer finswimmer merged commit 0a62649 into python-poetry:master Mar 9, 2022
@abn abn deleted the remove-build-requires branch March 9, 2022 23:57
DavidVujic pushed a commit to DavidVujic/poetry-core that referenced this pull request Mar 26, 2022
@abn @DavidVujic
remove dataclasses from build-system requires (python-poetry#304)
b1ec097
bostonrwalker pushed a commit to bostonrwalker/poetry-core that referenced this pull request Aug 29, 2022
@abn @bostonrwalker
remove dataclasses from build-system requires (python-poetry#304)
4ed8b24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finswimmer finswimmer finswimmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abn @finswimmer