Skip to content

Commit

Permalink
fix: disable wheel content validation (#7987)
Browse files Browse the repository at this point in the history
avoid out of memory issues

(cherry picked from commit 3ba800f)
  • Loading branch information
ralbertazzi authored and radoering committed May 29, 2023
1 parent a2175ff commit 19f76d5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/poetry/installation/wheel_installer.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,10 @@ def enable_bytecode_compilation(self, enable: bool = True) -> None:
def install(self, wheel: Path) -> None:
with WheelFile.open(wheel) as source:
try:
source.validate_record()
# Content validation is temporarily disabled because of
# pypa/installer's out of memory issues with big wheels. See
# https://github.com/python-poetry/poetry/issues/7983
source.validate_record(validate_contents=False)
except _WheelFileValidationError as e:
self.invalid_wheels[wheel] = e.issues
install(
Expand Down
1 change: 1 addition & 0 deletions tests/installation/test_executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,7 @@ def test_execute_prints_warning_for_yanked_package(
assert error.count("yanked") == 0


@pytest.mark.skip(reason="https://github.com/python-poetry/poetry/issues/7983")
def test_execute_prints_warning_for_invalid_wheels(
config: Config,
pool: RepositoryPool,
Expand Down

0 comments on commit 19f76d5

Please sign in to comment.