-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable wheel content validation #7987
Conversation
I added another commit where I achieve what I was saying here: #7983 (comment) This:
Cons: some pypa/installer code spilling into the Poetry codebase |
Not sure if the second commit is worth it or if we should just turn off validation until there is a solution in
The installer PR only reduces the memory consumption, the hash will still be computed twice, won't it? |
Correct, we would still need either a more invasive change of installer or this second commit |
d87f45a
to
87f6460
Compare
@radoering yes, I agree the PR still needs some touches. The way I got it is that we wouldn't have merged the additional work on top of the simple |
Yes, I think for 1.5.1 the first commit is fine. The second commit needs more work and testing. You can split the second commit into a separate PR if you want to keep working on it. |
87f6460
to
31561b3
Compare
avoid out of memory issues (cherry picked from commit 3ba800f)
avoid out of memory issues (cherry picked from commit 3ba800f)
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
Closes: #7983
First commit is a temporary solution to #7983 until pypa/installer#183 gets released.
Second commit is a permanent solution that also provides faster installation times.