Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VCS ignored files with poetry build #4800

Closed
1 task done
anth2o opened this issue Nov 19, 2021 · 4 comments · Fixed by #5656
Closed
1 task done

VCS ignored files with poetry build #4800

anth2o opened this issue Nov 19, 2021 · 4 comments · Fixed by #5656
Labels
area/docs Documentation issues/improvements

Comments

@anth2o
Copy link

anth2o commented Nov 19, 2021

  • I have searched the issues of this repo and believe that this is not a duplicate.

Issue

Hello there,
I spent some time figuring out that poetry build implicitly ignored files in the .gitignore. I had to look in the source code here to make sure my issue was coming from this behavior. I think it might be good to explicit this either in the documentation or in the CLI help of poetry build
Thanks
@anth2o anth2o added area/docs Documentation issues/improvements status/triage This issue needs to be triaged labels Nov 19, 2021
@finswimmer
Copy link
Member

Hello @anth2o,

it's mentioned here. But you are right, it would be good to make it clear in a more prominent way.

fin swimmer

@heavelock
Copy link

heavelock commented Nov 29, 2021 •
edited
Loading

I just bumped into the same issue. Is this behavior something that Poetry definitely wants to keep? Would a PR adding a flag that would turn off including .gitignore be accepted?

I just discovered that this behavior can be overcome by explicit include = [] in pyproject.toml. It would be great if this would be documented.

@plattfot plattfot mentioned this issue May 5, 2022
Closed
2 tasks
@Secrus Secrus added Good First Issue and removed status/triage This issue needs to be triaged labels May 16, 2022
@Secrus
Copy link
Member

Secrus commented May 16, 2022

I think adding a short note about explicit include overcoming VCS ignore file wouldn't hurt. PRs are welcome.

Secrus added a commit to Secrus/poetry that referenced this issue May 20, 2022
@Secrus
Changes in docs for Issues python-poetry#4800, python-poetry#3709, py…
a6d2520 
…thon-poetry#3573, python-poetry#2211, python-poetry#521 and PR python-poetry#2414

- Added section about `extras` in `dependency-specification.md` (python-poetry#2414)
- Added note about VCS inclusion and exclusion in `include`/`exclude`
sections of `pyproject.toml` (python-poetry#4800)
- Added link to dependency specification in `add` command documentation
(python-poetry#3573)
- Added more info on default behaviour and cleaned up
`virtualenv.in-project` setting documentation (python-poetry#3709)
- Added missing configuration options to `configuration.md` (python-poetry#2211)
@Secrus Secrus mentioned this issue May 20, 2022
Merged
1 task
neersighted pushed a commit that referenced this issue May 23, 2022
@Secrus @abn
Changes in docs for Issues #4800, #3709, #3573, #2211 and PR #2414 (#…
3349ba9 
…5656)

* Changes in docs for Issues #4800, #3709, #3573, #2211, #521 and PR #2414

- Added section about `extras` in `dependency-specification.md` (#2414)
- Added note about VCS inclusion and exclusion in `include`/`exclude`
sections of `pyproject.toml` (#4800)
- Added link to dependency specification in `add` command documentation
(#3573)
- Added more info on default behaviour and cleaned up
`virtualenv.in-project` setting documentation (#3709)
- Added missing configuration options to `configuration.md` (#2211)

Co-authored-by: Arun Babu Neelicattu <arun.neelicattu@gmail.com>
@abn abn mentioned this issue Jun 6, 2022
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/docs Documentation issues/improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes in docs for Issues #4800, #3709, #3573, #2211 and PR #2414 Secrus/poetry
4 participants
@finswimmer @heavelock @Secrus @anth2o