Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes in docs for Issues #4800, #3709, #3573, #2211 and PR #2414 #5656

Merged
merged 3 commits into from
May 23, 2022
Merged

Changes in docs for Issues #4800, #3709, #3573, #2211 and PR #2414 #5656

merged 3 commits into from
May 23, 2022

Conversation

Secrus
Copy link
Member

@Secrus Secrus commented May 20, 2022 •
edited
Loading

Pull Request Check List

Resolves: #4800
Resolves: #3709
Resolves: #3573
Resolves: #2211

@Secrus
Changes in docs for Issues python-poetry#4800, python-poetry#3709, py…
a6d2520 
…thon-poetry#3573, python-poetry#2211, python-poetry#521 and PR python-poetry#2414

- Added section about `extras` in `dependency-specification.md` (python-poetry#2414)
- Added note about VCS inclusion and exclusion in `include`/`exclude`
sections of `pyproject.toml` (python-poetry#4800)
- Added link to dependency specification in `add` command documentation
(python-poetry#3573)
- Added more info on default behaviour and cleaned up
`virtualenv.in-project` setting documentation (python-poetry#3709)
- Added missing configuration options to `configuration.md` (python-poetry#2211)
@Secrus Secrus added the area/docs Documentation issues/improvements label May 20, 2022
@Secrus Secrus requested a review from a team May 20, 2022 22:14
@github-actions
Copy link

github-actions bot commented May 20, 2022 •
edited
Loading

Deploy preview for website ready!

✅ Preview
https://website-cdxeo0epi-python-poetry.vercel.app

Built with commit 2730f67.
This pull request is being automatically deployed with vercel-action

abn
abn previously requested changes May 20, 2022
View reviewed changes
docs/configuration.md Outdated Show resolved Hide resolved
docs/configuration.md Outdated Show resolved Hide resolved
docs/dependency-specification.md Outdated Show resolved Hide resolved
docs/dependency-specification.md Show resolved Hide resolved
docs/pyproject.md Outdated Show resolved Hide resolved
Secrus and others added 2 commits May 21, 2022 02:43
@Secrus @abn
Apply suggestions from code review
8f29caa 
Co-authored-by: Arun Babu Neelicattu <arun.neelicattu@gmail.com>
@Secrus
Changes suggested by @abn and some cleanup of relative links
2730f67
@Secrus
Copy link
Member Author

Secrus commented May 21, 2022

Added some cleanup of syntax. Some links were based on direct syntax, changed it to Hugo templating to avoid issues.

@Secrus Secrus requested a review from abn May 21, 2022 01:06
@neersighted
Copy link
Member

Added some cleanup of syntax. Some links were based on direct syntax, changed it to Hugo templating to avoid issues.

Was there an actual issue with the links, or is this just an attempt to be more hygenic?

@Secrus
Copy link
Member Author

Secrus commented May 23, 2022

Added some cleanup of syntax. Some links were based on direct syntax, changed it to Hugo templating to avoid issues.

Was there an actual issue with the links, or is this just an attempt to be more hygenic?

Just being more hygenic. Whats more, Hugos relref will warn at compile time if ref can't be resolved, so it will save us from potential wrong links (at least internally to other docs pages).

@neersighted neersighted merged commit 3349ba9 into python-poetry:master May 23, 2022
@abn abn mentioned this pull request Jun 6, 2022
Merged
@Secrus Secrus deleted the few_docs_update branch June 21, 2022 13:25
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@neersighted neersighted neersighted approved these changes

@abn abn Awaiting requested review from abn

Assignees
No one assigned
Labels
area/docs Documentation issues/improvements
Projects
None yet
Milestone
No milestone
3 participants
@Secrus @neersighted @abn