Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP; RFC; Pending 1268, Stacked on 1270] Enhancement: git tag sem-ver resolution #1176

Closed
wants to merge 5 commits into from
Closed

[WIP; RFC; Pending 1268, Stacked on 1270] Enhancement: git tag sem-ver resolution #1176

wants to merge 5 commits into from

Conversation

dazza-codes
Copy link
Contributor

@dazza-codes dazza-codes commented Jun 19, 2019 •
edited
Loading

Issue(s)

Split out PRs

Not necessarily stacked, but isolated changes in smaller PRs:

Check List

  • Added tests for changed code.
  • Updated documentation for changed code.
  • Rebase on develop for new features and change PR target branch to develop

@dazza-codes dazza-codes changed the title WIP: Git tag semver [RFC, WIP]: Git tag sem-ver resolution Jun 20, 2019
@dazza-codes dazza-codes force-pushed the git-tag-semver branch 3 times, most recently from 882a5c1 to 2b4c095 Compare June 21, 2019 16:52
@dazza-codes dazza-codes changed the base branch from master to develop June 21, 2019 16:54
@dazza-codes dazza-codes force-pushed the git-tag-semver branch 3 times, most recently from 99e8cf3 to adaaa74 Compare June 21, 2019 17:37
@dazza-codes dazza-codes changed the title [RFC, WIP]: Git tag sem-ver resolution Git tag sem-ver resolution Jun 21, 2019
@dazza-codes dazza-codes mentioned this pull request Jun 21, 2019
Closed
2 tasks
@dazza-codes dazza-codes changed the title Git tag sem-ver resolution Enhancement: git tag sem-ver resolution Jun 28, 2019
@dazza-codes
Copy link
Contributor Author

tests are failing because test fixtures for a git repo do not support a git tag -l command

@dazza-codes dazza-codes force-pushed the git-tag-semver branch 3 times, most recently from 4112dc1 to 25f3d1b Compare July 31, 2019 17:37
@dazza-codes
Copy link
Contributor Author

Splitting this PR out into smaller PRs

@dazza-codes dazza-codes changed the title Enhancement: git tag sem-ver resolution [WIP, Stacking] Enhancement: git tag sem-ver resolution Jul 31, 2019
This was referenced Jul 31, 2019
Closed
Closed
Closed
@brycedrennan brycedrennan added the kind/feature Feature requests/implementations label Aug 9, 2019
@dazza-codes dazza-codes changed the title [WIP, Stacking] Enhancement: git tag sem-ver resolution [WIP, Stacked on 1270] Enhancement: git tag sem-ver resolution Aug 23, 2019
@dazza-codes dazza-codes force-pushed the git-tag-semver branch 4 times, most recently from d6b310d to 4cad13f Compare August 23, 2019 16:35
@dazza-codes dazza-codes force-pushed the git-tag-semver branch 2 times, most recently from 8f389da to 6d87e44 Compare September 12, 2019 18:39
Darren Weber added 4 commits September 12, 2019 11:50
Add Git.tags
421a382 
- add git tags to test fixtures
Add utils for poetry/semver
8fb8670 
- boolean check for a sem-ver string
- filter and sort a sequence of sem-ver strings
- these utils are used to filter and sort a list of git tags
Add Git.sem_ver_tags
814e80f 
- add utility methods for git tags
- use sem_ver_sorted for Git.sem_ver_tags
- extract private method for Git._folder_args
Add sem-ver tag support to git provider
92e2603 
- use sem-ver constraints to provide a git package
- add tests for git provider using tags
  - test a tag dependency
  - test a missing tag dependency
  - test a sem-ver tag dependency
- update README for git sem-ver tags
@dazza-codes dazza-codes changed the title [WIP, Stacked on 1270] Enhancement: git tag sem-ver resolution [Stacked on 1270] Enhancement: git tag sem-ver resolution Sep 12, 2019
@dazza-codes dazza-codes changed the title [Stacked on 1270] Enhancement: git tag sem-ver resolution [Pending 1268, Stacked on 1270] Enhancement: git tag sem-ver resolution Sep 13, 2019
@sdispater
Copy link
Member

I don't think that's something I am willing to add to Poetry. This is a very specific workflow (even though I understand why you might want it) that does not make sense to add to the Poetry code base.

@dazza-codes
Copy link
Contributor Author

dazza-codes commented Sep 13, 2019 •
edited
Loading

Interesting opinion, thanks for the transparency on that, it could save a lot of work. The options then are:

If this is a general feature veto, the options become:

  • fork permanently, which is not attractive
  • a plugin solution to provide this option
    • how does/could that work?

If this is an implementation veto, what are the options that could fly?

@sdispater
Copy link
Member

@darrenleeweber The truth is, that's a workflow that I was not aware of until now and npm seems to be the only one to support this.

But yes, going the plugin route might be the preferred way to implement this once the plugin system is done (see #1237)

@dazza-codes dazza-codes changed the title [Pending 1268, Stacked on 1270] Enhancement: git tag sem-ver resolution [WIP; Pending 1268, Stacked on 1270] Enhancement: git tag sem-ver resolution Sep 13, 2019
@dazza-codes dazza-codes changed the title [WIP; Pending 1268, Stacked on 1270] Enhancement: git tag sem-ver resolution [WIP; RFC; Pending 1268, Stacked on 1270] Enhancement: git tag sem-ver resolution Sep 13, 2019
@sdispater sdispater closed this Oct 5, 2019
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/feature Feature requests/implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dazza-codes @sdispater @brycedrennan