Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semver utils, using semver library #1268

Closed
wants to merge 3 commits into from

Conversation

dazza-codes
Copy link
Contributor

@dazza-codes dazza-codes commented Jul 31, 2019

  • boolean check for a sem-ver string
  • filter and sort a sequence of sem-ver strings
    • these utils are used to filter and sort a list of git tags in a subsequent PR

The focus of this PR is only on sem-ver support and not full PEP-0440 support, see:

Semantic versions containing a hyphen (pre-releases - clause 10) or a plus sign (builds - clause 11) are not compatible with this PEP and are not permitted in the public version field.

This implies that using parse_single_contraint and the poetry Version implementations may not be compatible with the intention of supporting sem-ver (assuming poetry aims only to support PEP-0440, although the poetry philosophy seems to be not to impose a specific versioning strategy on the user). This PR is focused on sem-ver support (given that full sem-ver support is not 100% compatible with PEP-0440). The responsibility for sem-ver parsing belongs with the semver dependency, to avoid recreating that wheel.

checklist

  • Added tests for changed code.
  • Updated documentation for changed code
    • no API docs required for this, AFAIK

tests/semver/test_sem_ver_utils.py Outdated Show resolved Hide resolved
tests/semver/test_sem_ver_utils.py Outdated Show resolved Hide resolved
@brycedrennan brycedrennan added the kind/feature Feature requests/implementations label Aug 16, 2019
@dazza-codes dazza-codes force-pushed the semver-utils branch 6 times, most recently from 9667849 to c51df8f Compare August 23, 2019 15:24
@dazza-codes dazza-codes force-pushed the semver-utils branch 3 times, most recently from 1a25012 to 5effab1 Compare September 12, 2019 23:10
@dazza-codes dazza-codes force-pushed the semver-utils branch 2 times, most recently from 5bffc45 to 36c81d7 Compare September 13, 2019 15:59
@dazza-codes dazza-codes force-pushed the semver-utils branch 2 times, most recently from 70442c0 to aad50fb Compare October 5, 2019 18:28
- use the semver dependency
- boolean check for a sem-ver string
- filter and sort a sequence of sem-ver strings
@dazza-codes dazza-codes changed the title Add utils for poetry/semver Add semver utils, using semver library Oct 5, 2019
@stale
Copy link

stale bot commented Dec 4, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 4, 2019
@dazza-codes
Copy link
Contributor Author

I'm kinda giving up on contributing to poetry

  • the review and merge cycle takes too long
  • the project doesn't appear to be open to easy modifications or even simple refactoring

@stale stale bot removed the stale label Dec 5, 2019
@Secrus Secrus closed this May 21, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants