-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add semver utils, using semver library #1268
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
dazza-codes
force-pushed
the
semver-utils
branch
from
August 10, 2019 00:09
4e4e6cb
to
06200a9
Compare
dazza-codes
force-pushed
the
semver-utils
branch
6 times, most recently
from
August 23, 2019 15:24
9667849
to
c51df8f
Compare
dazza-codes
force-pushed
the
semver-utils
branch
from
September 5, 2019 16:02
c51df8f
to
fa82890
Compare
dazza-codes
force-pushed
the
semver-utils
branch
3 times, most recently
from
September 12, 2019 23:10
1a25012
to
5effab1
Compare
dazza-codes
force-pushed
the
semver-utils
branch
2 times, most recently
from
September 13, 2019 15:59
5bffc45
to
36c81d7
Compare
2 tasks
2 tasks
dazza-codes
force-pushed
the
semver-utils
branch
2 times, most recently
from
October 5, 2019 18:28
70442c0
to
aad50fb
Compare
- use the semver dependency - boolean check for a sem-ver string - filter and sort a sequence of sem-ver strings
dazza-codes
force-pushed
the
semver-utils
branch
from
October 5, 2019 18:41
aad50fb
to
bbf869a
Compare
dazza-codes
changed the title
Add utils for poetry/semver
Add semver utils, using semver library
Oct 5, 2019
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I'm kinda giving up on contributing to poetry
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The focus of this PR is only on sem-ver support and not full PEP-0440 support, see:
This implies that using
parse_single_contraint
and the poetryVersion
implementations may not be compatible with the intention of supporting sem-ver (assuming poetry aims only to support PEP-0440, although the poetry philosophy seems to be not to impose a specific versioning strategy on the user). This PR is focused on sem-ver support (given that full sem-ver support is not 100% compatible with PEP-0440). The responsibility for sem-ver parsing belongs with thesemver
dependency, to avoid recreating that wheel.checklist