directory dependency - resolve relative paths #2047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapilt
force-pushed
the
bug/dir-builder-relative-resolve
branch
from
485d983 to
ebb97f0
Compare
kapilt
force-pushed
the
bug/dir-builder-relative-resolve
branch
from
ebb97f0 to
95efc30
Compare
3 tasks
|
looks like the exception (filenotfound on 3.5) needs to be casted for the existing test that wants a valueerror here. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #2046 by resolving relative references in directory paths, with this build --format=wheel and build --format=sdist both work, albeit with an unconstrained dep name in generated PKG-INFO.
Pull Request Check List