Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish: raise an error on redirects #3083

Merged
merged 1 commit into from
Oct 13, 2020
Merged

publish: raise an error on redirects #3083

merged 1 commit into from
Oct 13, 2020

Conversation

ObserverOfTime
Copy link
Contributor

Resolves: #3069

  • Added tests for changed code.
  • Updated documentation for changed code.

I have a few questions regarding my changes:

  • Should I add a helpful note in the documentation?
  • Does the uploader need to also handle 302 redirects?
  • Should the error message be consistent with 4xx errors?

@finswimmer finswimmer requested a review from a team October 5, 2020 18:58
poetry/publishing/uploader.py Outdated Show resolved Hide resolved
@abn abn merged commit 3e42be1 into python-poetry:master Oct 13, 2020
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publish: raise an error on redirects due to trailing slashes
2 participants