Raise UploadError when HTTP 308 occurs when publishing #3315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObserverOfTime
approved these changes
Nov 1, 2020
neersighted
requested changes
Nov 14, 2021
| @@ -46,6 +46,18 @@ def test_uploader_properly_handles_301_redirects(http): | |||
| ) | |||
|
|
|||
|
|
|||
| def test_uploader_properly_handles_308_redirects(http): | |||
There was a problem hiding this comment.
To avoid copy-pasting, let's parameterize this test instead.
| @@ -272,7 +272,7 @@ def _upload_file( | |||
| ) | |||
| ) | |||
| bar.finish() | |||
| elif resp.status_code == 301: | |||
| elif resp.status_code in (301, 308): | |||
There was a problem hiding this comment.
Since we're dropping Python 2 support, let's take advantage of the enums in https://docs.python.org/3/library/http.html#http.HTTPStatus instead of using the raw status codes.
|
Changes made in this PR were added to the code base. Closing. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #742
Related PR: #3083
I was experiencing HTTP redirect errors on poetry v1.14.0, even though 301 redirects are being handled properly. It appears I was getting a 308. I have added the 308 so that it will be caught and added a new test.
@ObserverOfTime You recently worked on this as well. Could you have a look and share your thoughts?