Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix utils.env.SystemEnv.run("python", ... on Windows #727

Closed
wants to merge 1 commit into from

Conversation

asodeur
Copy link
Contributor

@asodeur asodeur commented Dec 11, 2018

Pull Request Check List

Fixes the issue that poetry does always use the primary system interpreter on Windows when called like
<some path>\python.exe -m poetry and <some path> is not inside a virtual environment, see #655.

Maybe superseeded by PR #731.

  • Added tests for changed code. Not sure how to test this beyond trivial unit tests as pretty specific setup involving at least two interpreters is required.

@asodeur
Copy link
Contributor Author

asodeur commented Feb 11, 2019

#882 is a version of this based on master

@asodeur asodeur closed this Feb 11, 2019
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant