Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix utils.env.SystemEnv.run("python", ... on Windows #882

Closed
wants to merge 3 commits into from

Conversation

asodeur
Copy link
Contributor

@asodeur asodeur commented Feb 11, 2019

Fixes the issue that poetry does always use the primary system interpreter on Windows when called like
<some path>\python.exe -m poetry and <some path> is not inside a virtual environment, see #655.

Maybe superseeded by PR #731.

  • Added tests for changed code. Not sure how to test this beyond trivial unit tests as pretty specific setup involving at least two interpreters is required.

#727 is a previous version of this which was based on the develop branch

@brycedrennan brycedrennan added the kind/bug Something isn't working as expected label Aug 17, 2019
@stale
Copy link

stale bot commented Nov 13, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 13, 2019
@sdispater sdispater added stale and removed wontfix labels Nov 14, 2019
@stale stale bot removed the stale label Nov 14, 2019
@finswimmer finswimmer closed this Jan 22, 2020
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants