Fixed failed unit tests caused by using pytz inappropriately
#621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the document https://pythonhosted.org/pytz/ : `Unfortunately using the tzinfo argument of the standard datetime constructors 'does not work' with pytz for many timezones`. This fixes python-restx#620
|
Thanks @buttonfly1000 Here is some background on the issue: https://engineering.backmarket.com/moving-forward-in-pythons-time-and-time-zones-aa3ccbd4569a I think we need to remove |
|
In #622 I replaced pytz with stdlib equivalents. |
|
@foarsitter I agree, moving to stdlib is the way to go here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the document https://pythonhosted.org/pytz/ :
Unfortunately using the tzinfo argument of the standard datetime constructors 'does not work' with pytz for many timezones.This fixes #620