Replace pytz with zoneinfo / datetime.timezone #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts.zoneinfo for python 3.8
|
Can someone run the failed test again because of the fatal Python error: Segmentation fault? |
|
@foarsitter Sorry I've not been active much lately. Will get this reviewed and merged this week. I think we will need to deprecate Python 3.8 support for this, but that is okay because as you say on the other PR it's EOL now anyways. |
|
@peter-doggart no worries, let me know if I can do something. |
peter-doggart
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytz 2024.1 breaks the test suite.
This PR replaces pytz with the stdlib equivalents.