Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What happened to BlockingTrioPortal? #1167

Closed
jtrakk opened this issue Aug 1, 2019 · 5 comments · Fixed by #1168
Closed

What happened to BlockingTrioPortal? #1167

jtrakk opened this issue Aug 1, 2019 · 5 comments · Fixed by #1168

Comments

@jtrakk
Copy link
Contributor

jtrakk commented Aug 1, 2019 •
edited
Loading

It has disappeared in 0.12.0 but I don't see anything in the changelog. The PR seems to be this one.
@njsmith
Copy link
Member

njsmith commented Aug 1, 2019

Oh shoot, it was supposed to be deprecated in favor of the new trio.from_thread functions, but apparently we made some kind of mistake in the deprecation. It's supposed to still exist but give a warning; instead it doesn't exist at all.

njsmith added a commit to njsmith/trio that referenced this issue Aug 1, 2019
@njsmith
Put BlockingTrioPortal back where it's supposed to be.
d001f20 
When it was deprecated in python-triogh-1122, it accidentally got moved into
trio.hazmat.

Fixes: python-triogh-1167
@njsmith njsmith mentioned this issue Aug 1, 2019
Merged
@njsmith
Copy link
Member

njsmith commented Aug 1, 2019

Oh heh, it accidentally got moved to trio.hazmat and I didn't notice during the review. See #1168

@jtrakk
Copy link
Contributor Author

jtrakk commented Aug 1, 2019

Should the 0.12.0 changelog mention the deprecation as well?

njsmith added a commit to njsmith/trio that referenced this issue Aug 1, 2019
@njsmith
Put BlockingTrioPortal back where it's supposed to be.
da5f90c 
When it was deprecated in python-triogh-1122, it accidentally got moved into
trio.hazmat.

Fixes: python-triogh-1167
@njsmith
Copy link
Member

njsmith commented Aug 1, 2019

@jtrakk Yeah, it totally should. It looks like when I was reviewing #1122, I had a total brain-fart and forgot to ask for a newsfragment! 🤦‍♂️ I've added that to the PR in #1168 as well.

@njsmith
Copy link
Member

njsmith commented Aug 1, 2019

Btw, CC @epellis – none of this is your fault, it's my fault for missing it during the review, but still probably useful to look over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Put BlockingTrioPortal back where it's supposed to be. njsmith/trio
2 participants
@njsmith @jtrakk