Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put BlockingTrioPortal back where it's supposed to be. #1168

Merged

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented Aug 1, 2019

When it was deprecated in gh-1122, it accidentally got moved into
trio.hazmat.

Fixes: gh-1167

@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #1168 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1168      +/-   ##
==========================================
+ Coverage   99.55%   99.55%   +<.01%     
==========================================
  Files         106      106              
  Lines       12747    12751       +4     
  Branches      978      978              
==========================================
+ Hits        12690    12694       +4     
  Misses         36       36              
  Partials       21       21
Impacted Files Coverage Δ
trio/__init__.py 100% <ø> (ø) ⬆️
trio/tests/test_threads.py 100% <100%> (ø) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #1168 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1168      +/-   ##
==========================================
+ Coverage   99.55%   99.55%   +<.01%     
==========================================
  Files         106      106              
  Lines       12747    12751       +4     
  Branches      978      978              
==========================================
+ Hits        12690    12694       +4     
  Misses         36       36              
  Partials       21       21
Impacted Files Coverage Δ
trio/__init__.py 100% <ø> (ø) ⬆️
trio/tests/test_threads.py 100% <100%> (ø) ⬆️

njsmith added 2 commits August 1, 2019 00:28
When it was deprecated in python-triogh-1122, it accidentally got moved into
trio.hazmat.

Fixes: python-triogh-1167
@njsmith njsmith force-pushed the fix-blocking-trio-portal-deprecation branch from d001f20 to 2a58e45 Compare August 1, 2019 07:36
@oremanj oremanj merged commit 5c81257 into python-trio:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What happened to BlockingTrioPortal?
2 participants