Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the autojump task #1588

Merged
merged 10 commits into from
Jun 9, 2020
Merged

Remove the autojump task #1588

merged 10 commits into from
Jun 9, 2020

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented Jun 9, 2020

This is probably easiest to review in one-commit-at-a-time mode

Alternative to #1579

Fixes #1587

@njsmith njsmith requested a review from oremanj June 9, 2020 04:57
@njsmith njsmith mentioned this pull request Jun 9, 2020
Closed
@codecov
Copy link

codecov bot commented Jun 9, 2020 •
edited
Loading

Codecov Report

Merging #1588 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1588      +/-   ##
==========================================
- Coverage   99.69%   99.69%   -0.01%     
==========================================
  Files         111      110       -1     
  Lines       13869    13849      -20     
  Branches     1060     1056       -4     
==========================================
- Hits        13827    13807      -20     
  Misses         27       27              
  Partials       15       15
Impacted Files Coverage Δ
trio/tests/test_testing.py 100.00% <ø> (ø)
trio/_core/__init__.py 100.00% <100.00%> (ø)
trio/_core/_mock_clock.py 100.00% <100.00%> (ø)
trio/_core/_run.py 99.76% <100.00%> (+<0.01%) ⬆️
trio/_core/tests/test_guest_mode.py 100.00% <100.00%> (ø)
trio/_core/tests/test_mock_clock.py 100.00% <100.00%> (ø)
trio/testing/__init__.py 100.00% <100.00%> (ø)
trio/tests/test_exports.py 97.22% <0.00%> (-0.15%) ⬇️
trio/__init__.py 100.00% <0.00%> (ø)
trio/_threads.py 100.00% <0.00%> (ø)
... and 4 more

@njsmith njsmith mentioned this pull request Jun 9, 2020
Open
oremanj
oremanj approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@oremanj oremanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I agree that this seems a better path forward than #1579. A few small suggestions; feel free to merge once you've addressed to your satisfaction.

trio/_core/_mock_clock.py Show resolved Hide resolved
trio/_core/_run.py Outdated Show resolved Hide resolved
trio/_core/tests/test_guest_mode.py Outdated Show resolved Hide resolved
@oremanj oremanj mentioned this pull request Jun 9, 2020
Merged
@njsmith njsmith force-pushed the autojump-without-a-task branch from 6fa1435 to 6b4341c Compare June 9, 2020 23:16
@njsmith njsmith merged commit eadb499 into python-trio:master Jun 9, 2020
@njsmith njsmith deleted the autojump-without-a-task branch June 9, 2020 23:50
njsmith added a commit to njsmith/trio that referenced this pull request Jun 10, 2020
@njsmith
Deprecate the tiebreaker= argument to wait_all_tasks_blocked
27989c9 
It was only added for the autojump clock, it wasn't very good at that,
and since python-triogh-1588, the autojump clock doesn't even use it anyway.
@njsmith njsmith mentioned this pull request Jun 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oremanj oremanj oremanj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting rid of the autojump task
2 participants
@njsmith @oremanj