Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the tiebreaker= argument to wait_all_tasks_blocked #1598

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented Jun 10, 2020

It was only added for the autojump clock, it wasn't very good at that,
and since gh-1588, the autojump clock doesn't even use it anyway.

It was only added for the autojump clock, it wasn't very good at that,
and since python-triogh-1588, the autojump clock doesn't even use it anyway.
@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #1598 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1598      +/-   ##
==========================================
- Coverage   99.69%   99.69%   -0.01%     
==========================================
  Files         110      110              
  Lines       13849    13848       -1     
  Branches     1056     1056              
==========================================
- Hits        13807    13806       -1     
  Misses         27       27              
  Partials       15       15              
Impacted Files Coverage Δ
trio/_core/_run.py 99.76% <100.00%> (+<0.01%) ⬆️
trio/_core/tests/test_mock_clock.py 100.00% <100.00%> (ø)
trio/tests/test_testing.py 100.00% <100.00%> (ø)

@oremanj
Copy link
Member

oremanj commented Jun 10, 2020

test_highlevel_open_tcp_listeners check_backlog failure again

@oremanj oremanj closed this Jun 10, 2020
@oremanj oremanj reopened this Jun 10, 2020
@pquentin pquentin merged commit ffb1b12 into python-trio:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants