Enable ruff flake8-builtins rule

[CoolCat467]

This pull request enables ruff's flake8-builtins rule, sorts the enabled rules and ignored rules sections, and fixes or ignores a lot of newly generated "argument or variable is shadowing a python builtin" errors.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0204d04) 99.64% compared to head (67116bc) 99.64%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2930   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         116      116           
  Lines       17503    17503           
  Branches     3148     3148           
=======================================
  Hits        17441    17441           
  Misses         43       43           
  Partials       19       19           

Files	Coverage Δ
src/trio/_core/_io_kqueue.py	87.20% <100.00%> (ø)
src/trio/_core/_tests/test_asyncgen.py	100.00% <100.00%> (ø)
src/trio/_highlevel_open_tcp_listeners.py	100.00% <100.00%> (ø)
src/trio/_socket.py	100.00% <100.00%> (ø)
src/trio/_subprocess.py	100.00% <100.00%> (ø)
...c/trio/_tests/test_highlevel_open_tcp_listeners.py	100.00% <100.00%> (ø)
src/trio/_tests/test_highlevel_open_tcp_stream.py	100.00% <100.00%> (ø)
src/trio/_tests/test_socket.py	100.00% <100.00%> (ø)
src/trio/testing/_fake_net.py	100.00% <100.00%> (ø)

[Fuyukai]

Why is this three separate PRs that will all conflict due to all three reformattting the pyproject.toml?

[CoolCat467]

Because they are separate rules, and if they conflict I will deal with that.

[CoolCat467]

The segfault in pypy-3.9 happened again: https://github.com/python-trio/trio/actions/runs/7607032357/job/20713702030#step:5:1186
For future reference, where should these be recorded?

[A5rocks]

Gah, well see the segfaults don't exactly provide much information... But I agree that it's annoying. At this point ig we might as well make an issue here (on trio) to track things cause upstream pytest hasn't been able to solve this yet.

---

Also, I don't really see the use of this rule. We have type checkers; I don't see the issue with this shadowing. Maybe others see issue though?

[CoolCat467]

In all reality we might not need flake8-builtins, but I wanted to throw it out there because it's a part of best practice not to shadow builtins.

[jakkdl]

I'm in favor of not shadowing builtins in general, type checking might catch most errors it might lead to (only if the object is different though!) - but I can definitely see it causing confusion/lead to bugs/etc.

[jakkdl]

actually, after reading through all the diffs I think we should ignore A002 - but we could keep A001. We're never going to change the argument names for external-facing functions, and I'm not sure it's worth the need for lots of ugly noqas to be extra safe on internal functions.

[jakkdl]

Looks great!