Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable flake8-comprehensions #2931

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

CoolCat467
Copy link
Member

This pull request enables ruff's flake8-comprehensions rule, building off of the formatting changes done in #2930.

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e0d8edf) 99.64% compared to head (a1b8bd1) 99.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2931   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         116      116           
  Lines       17501    17501           
  Branches     3148     3148           
=======================================
  Hits        17439    17439           
  Misses         43       43           
  Partials       19       19           

@jakkdl
Copy link
Member

jakkdl commented Jan 24, 2024

See https://pypi.org/project/flake8-comprehensions/ for what this rule does

@jakkdl jakkdl merged commit b780204 into python-trio:master Jan 24, 2024
27 checks passed
@CoolCat467 CoolCat467 deleted the enable-flake8-comprehensions branch January 24, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants