Skip to content

fix typo, clean up test_traceback_frame_removal #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakkdl merged 1 commit into from
May 23, 2025
Merged

fix typo, clean up test_traceback_frame_removal #3272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions src/trio/_core/_tests/test_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2130,17 +2130,12 @@ def check_traceback(exc: KeyError) -> bool:
assert tb is not None
return tb.tb_frame.f_code is my_child_task.__code__

expected_exception = Matcher(KeyError, check=check_traceback)

with RaisesGroup(expected_exception, expected_exception):
# Trick: For now cancel/nursery scopes still leave a bunch of tb gunk
# behind. But if there's an ExceptionGroup, they leave it on the group,
# which lets us get a clean look at the KeyError itself. Someday I
# guess this will always be an ExceptionGroup (#611), but for now we can
# force it by raising two exceptions.
with RaisesGroup(Matcher(KeyError, check=check_traceback)):
# For now cancel/nursery scopes still leave a bunch of tb gunk behind.
# But if there's an Exceptiongroup, they leave it on the group,
# which lets us get a clean look at the KeyError itself.
async with _core.open_nursery() as nursery:
nursery.start_soon(my_child_task)
nursery.start_soon(my_child_task)


def test_contextvar_support() -> None:
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ deps =
setuptools
cython
set_env =
CFLAGS= -DCYTHON_TRACE_NOGIL=1A
CFLAGS= -DCYTHON_TRACE_NOGIL=1
allowlist_externals =
sed
cp
Expand Down
Loading