Skip to content

maint: minor improvements #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2023
Merged

maint: minor improvements #232

merged 1 commit into from
Mar 3, 2023

Conversation

yozachar
Copy link
Collaborator

@yozachar yozachar commented Mar 3, 2023

  • removes internal module _extremes.py from __init__.py
  • moves segwit pattern compilation to func
  • makes card's value parameter positional-only
  • uses functools.wraps to preserve wrapped func signature

This PR will be open for review, for just 1 hour, from creation, as these changes very small.

@yozachar
maint: minor improvements
35e0edd 
- removes internal module `_extremes.py` from `__init__.py`
- moves segwit pattern compilation to func
- makes card's `value` parameter positional-only
- uses `functools.wraps` to preserve wrapped func signature
@yozachar yozachar self-assigned this Mar 3, 2023
@yozachar yozachar added review PR: Can be reviewed and removed review PR: Can be reviewed labels Mar 3, 2023
@yozachar yozachar merged commit a5071c6 into python-validators:master Mar 3, 2023
kvesteri
kvesteri reviewed Mar 3, 2023
View reviewed changes
@yozachar yozachar mentioned this pull request Mar 3, 2023
Merged
yozachar referenced this pull request Mar 3, 2023
@yozachar
maint: improves domain module
7489857 
- Uses type hints, improve docs
- Regards [RFC 1034](https://www.rfc-editor.org/rfc/rfc1034) and [RFC 2782](https://www.rfc-editor.org/rfc/rfc2782)
- Updates corresponding test functions

**Related items**

*Issues*

- Closes #52
- Closes #74
- Closes #81
- Closes #89
- Closes #95
- Closes #120
- Closes #124
- Closes #141
- Closes #143
- Closes #199
- Closes #204

*PRs*

- Closes #114
- Closes #179
@yozachar yozachar added the maintenance PR: Alters existing source code label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kvesteri kvesteri kvesteri left review comments

Assignees

@yozachar yozachar

Labels

maintenance PR: Alters existing source code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yozachar @kvesteri